Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-02] Research what needs to happen before we merge a PR #107

Open
benjie opened this issue Feb 28, 2024 · 1 comment
Open

[2024-02] Research what needs to happen before we merge a PR #107

benjie opened this issue Feb 28, 2024 · 1 comment
Assignees

Comments

@benjie
Copy link
Member

benjie commented Feb 28, 2024

Does it need particular labels? Do we need to ensure the commit message is in a particular format? Do they need to add a changeset or documentation? Also gather requirements (two approvals, etc) from CONTRIBUTING.md


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@yaacovCR
Copy link
Contributor

Just a note to remind myself like some work should ideally be done before a PR is merged but could be done after. In particular, the label of breaking/feature/fix/polish/internal is used at release time by an internal script so it is forgiving if these labels are added later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants