Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid Component.defaultProps for icon components #3602

Merged
merged 1 commit into from
May 14, 2024

Conversation

thomasheyenbrock
Copy link
Collaborator

Setting Component.defaultProps issues some warnings in the console as the feature is considered deprecated. Replacing it with spreading component props with a default value instead.

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 34fc275

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphiql/react Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.32%. Comparing base (e3ca774) to head (34fc275).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3602   +/-   ##
=======================================
  Coverage   55.31%   55.32%           
=======================================
  Files         115      115           
  Lines        5351     5352    +1     
  Branches     1451     1451           
=======================================
+ Hits         2960     2961    +1     
  Misses       1965     1965           
  Partials      426      426           
Files Coverage Δ
packages/graphiql-react/src/icons/index.tsx 100.00% <100.00%> (ø)

Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphiql@3.2.3-canary-0dd016c7.0
@graphiql/plugin-code-exporter@3.0.2-canary-0dd016c7.0
@graphiql/plugin-explorer@3.0.2-canary-0dd016c7.0
@graphiql/react@0.22.2-canary-0dd016c7.0

@thomasheyenbrock thomasheyenbrock merged commit 03ab3a6 into main May 14, 2024
14 checks passed
@thomasheyenbrock thomasheyenbrock deleted the avoid-default-props branch May 14, 2024 21:14
@acao acao mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant