Use the prod distribution of React in graphiql.html #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranron
added
enhancement
tyranron
requested changes
Jan 29, 2024
There was a problem hiding this comment.
@kiendang thank you!
However, this file is auto-downloaded from the upstream repo, and so:
- either better contribute this change to the upstream repo;
- or add post-processing commands doing the substitution.
|
Ah I see. I actually did just that a while back, opening a PR in the graphiql repo graphql/graphiql#3402 but it got closed and I didn't really understand the reason. |
|
@kiendang let's adjust post-processing in |
kiendang
force-pushed
the
graphiql-react-prod
branch
from
3a84a69
to
1e90960
Compare
tyranron
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reduce bundle size