Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: fix ssh issues with netconf #172101

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

gaige
Copy link
Sponsor Contributor

@gaige gaige commented May 19, 2024

Recent updates to netconf (for working with routers) require pylibssh in order to
work consistently. This commit adds ansible-pylibssh in order to resolve errors when
communicating with routers using vyos and junos (at a minimum).

Adds libssh as a dependency, which is necessary for build and will cause an error
if run without it.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels May 19, 2024
@gaige gaige force-pushed the ansible-pylibssh branch 2 times, most recently from 893478c to 97d4284 Compare May 19, 2024 11:13
@SMillerDev
Copy link
Member

This will be removed in the next version bump unless it's also added to the pypy configuration JSON at the root of the repo

@gaige
Copy link
Sponsor Contributor Author

gaige commented May 20, 2024

This will be removed in the next version bump unless it's also added to the pypy configuration JSON at the root of the repo

I wasn't aware. Updating, testing, re-auditing now.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 20, 2024
@gaige
Copy link
Sponsor Contributor Author

gaige commented May 21, 2024

@SMillerDev Updated with changes to the additional file. LMK if there is anything else.

Thanks!

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaige ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@SMillerDev SMillerDev added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024
@gaige
Copy link
Sponsor Contributor Author

gaige commented May 22, 2024

@SMillerDev Curious about the merge failure here. Any recommendations?

@SMillerDev
Copy link
Member

Could you rebase this PR?

@gaige
Copy link
Sponsor Contributor Author

gaige commented May 22, 2024

On it

Recent updates to netconf (for working with routers) require pylibssh in order to
work consistently. This commit adds ansible-pylibssh in order to resolve errors when
communicating with routers using vyos and junos (at a minimum).

Adds libssh as a dependency, which is necessary for build and will cause an error
if run without it.
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label May 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label May 22, 2024
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 22, 2024
Copy link
Contributor

⚠️ Failed to enable automerge.

@gaige gaige requested a review from SMillerDev May 22, 2024 09:34
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label May 22, 2024
@carlocab carlocab enabled auto-merge May 22, 2024 10:09
@carlocab carlocab added this pull request to the merge queue May 22, 2024
Merged via the queue into Homebrew:master with commit 2479b20 May 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants