mpv formula is missing molten-vk as a dependency

[rgaufman]

Without molten-vk as a dependency, the vulkan-loader and vulkan-headers dependencies are useless and mpv cannot work in an optimal way and shows "VK_ERROR_INCOMPATIBLE_DRIVER" on start.

More details here: mpv-player/mpv#14173

Simple solution is to add molten-vk as a dependency.

Verification

• My brew doctor output says Your system is ready to brew. and am still able to reproduce my issue.
• I ran brew update and am still able to reproduce my issue.
• I have resolved all warnings from brew doctor and that did not fix my problem.
• I searched for recent similar issues at https://github.com/Homebrew/homebrew-core/issues?q=is%3Aissue and found no duplicates.

What were you trying to do (and why)?

brew install mpv
mpv filename

What happened (include all command output)?

It installed but because of the missing dependency it was slow and glitchy

What did you expect to happen?

For molten-vk to be installed automatically as a dependency

Step-by-step reproduction instructions (by running brew commands)

1. brew install mpv
2. Playback a file with mpv -v filename and notice the VK_ERROR_INCOMPATIBLE_DRIVER errors and slow performance

[carlocab]

So, to be sure: this doesn't apply to installs of the stable version? Does this mean molten-vk will be required in a future release of MPV?

[rgaufman]

It applies to any natively running mpv, the "stable" cask version unfortunately isn't running natively but through rosetta.

[carlocab]

To be clear, I wasn't referring to the cask. So this is needed when you do

brew install --formula mpv

too? (Note: without --HEAD)

Is it only required on Apple Silicon? Or is it needed on Intel macOS too?

[rgaufman]

Ah, sorry, yes with mpv -v filename it throws the same errors: VK_ERROR_INCOMPATIBLE_DRIVER because molten-vk is missing.

[carlocab]

Ok, thanks. You mentioned the problem not appearing when running in Rosetta. Does that mean this dependency is not required on Intel macOS?

[rgaufman]

I checked with an mpv developer and he said molten-vk is recommended for any mpv user with a modern MacOS, regardless of architecture.