Skip to content

Commit

Permalink
Remove ZydisPE
Browse files Browse the repository at this point in the history
The PE parsing code is wildly unsafe and doesn't perform any input validation.
It was originally written as an example on how to use our formatter API for
using custom symbols in disassembly output. However, living in the `tools`
directory incorrectly suggested to users that it's a safe tool intended for
actual public use.

Following a security report, we decided to just delete it for the time being,
possibly bringing it back later.

We intentionally never defined install rules for it (it's not installed on
`make install`) and also don't ship it in the packages of any package manager
repository, so the practical security impact should be low.
  • Loading branch information
athre0z committed Oct 22, 2021
1 parent 6ae9f61 commit 869dfb4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 1,196 deletions.
8 changes: 0 additions & 8 deletions CMakeLists.txt
Expand Up @@ -306,13 +306,5 @@ if (ZYDIS_BUILD_TOOLS AND NOT ZYAN_NO_LIBC)
zyan_maybe_enable_wpo("ZydisInfo")
_maybe_set_emscripten_cfg("ZydisInfo")
install(TARGETS "ZydisInfo" RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR})

add_executable("ZydisPE" "tools/ZydisPE.c")
target_link_libraries("ZydisPE" "Zydis")
set_target_properties ("ZydisPE" PROPERTIES FOLDER "Tools")
target_compile_definitions("ZydisPE" PRIVATE "_CRT_SECURE_NO_WARNINGS")
zyan_set_common_flags("ZydisPE")
zyan_maybe_enable_wpo("ZydisPE")
_maybe_set_emscripten_cfg("ZydisPE")
endif ()
endif ()

0 comments on commit 869dfb4

Please sign in to comment.