Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub Parameter Values Left Stale & New Parameter Created After Multi Byte Parameter Update #6801

Open
3 tasks done
The00Dustin opened this issue Mar 28, 2024 · 4 comments
Open
3 tasks done
Labels
bug Something isn't working

Comments

@The00Dustin
Copy link
Contributor

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Home Assistant Add-on

Z-Wave JS UI version

9.9.1

ZwaveJS version

12.4.4

Describe the bug

When, using a HomeAssistant service, I send a multi byte value to a multi byte parameter that is listed in Z-Wave JS UI as separate sub parameters, Z-Wave JS UI adds a new parameter for that value update and leaves the sub parameters stale. If a sub parameter is updated afterwards, the multi byte parameter will be stale. Refreshing values will correct the sub parameters, but not the multi byte parameter.

To Reproduce

Review the end of the configuration parameters before and after taking the step mentioned in the description. In the reproduction steps I took for creating logs for this issue, I used the following service call:

service: zwave_js.bulk_set_partial_config_parameters
data:
  parameter: "99"
  value: 25191679
target:
  entity_id: light.media_light

Expected behavior

The sub parameters should have their values updated from the multi-byte event, and if the multi-byte parameter should also exist, it should also update when notified of changes to the sub parameters and during refreshing values.

Additional context

Here is a screen snippet before sending the multi-byte parameter value:
Screenshot 2024-03-28 at 13 12 31

Here is a screen snippet after sending the multi-byte parameter value:
Screenshot 2024-03-28 at 13 20 21

Here are the logs:
zwave-js-ui-store.zip

Here are UTC timestamps to go with the logs (Node 12):
17:11 - Reinterview
17:17 - Send multi byte value - see that new property is created & old sub parameters aren't updated
17:25 - Refresh values - see that sub parameters are now all updated
17:26 - Send single byte value (with Z-Wave JS UI) - see that new property isn't updated

*I did more testing after 17:26 repeating the last two steps & sending the single byte value with the service, but didn't see any differences in behavior, the new multi byte parameter stayed the same as shown in the second screen snippet.

@The00Dustin The00Dustin added the bug Something isn't working label Mar 28, 2024
@robertsLando
Copy link
Member

I don't think this is something related to Z-UI side, maybe an event missing from Z-Wave JS? It's not 100% clear what you are doing here as I never did such operation, @AlCalzone any idea?

@AlCalzone
Copy link
Member

Yeah this was supposed to be opened in the node-zwave-js repo

@The00Dustin
Copy link
Contributor Author

Sorry about that, makes sense now that I think about it. I see the sub-parameters in UI, but I guess they are technically exposed to HA, which puts them in node. Should I close and re-open this, or can it be moved?

@AlCalzone
Copy link
Member

I'll move it, it's fine. If something is missing that the other issue template asks for, I'll get back to you.

@robertsLando robertsLando transferred this issue from zwave-js/zwave-js-ui Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants