Loss of 0 when combining Version and SubVersion

[duylong]

Checklist

• I have read and followed the above instructions

• I have checked the troubleshooting section and my problem is not described there.

• I have read the changelog and my problem was not mentioned there or the fix did not work.

Describe the issue

Hi,

I recently contacted Aeotec support and found that in some cases the firmware numbers were different between Zwave JS UI and Aeotec.

They explained to me that some softwares drop the 0 when combining "Version" and "SubVersion" together.

For example:

    V1.60 means
        Version 01
        SubVersion 60
    V1.06 means
        Version 01
        SubVersion 06

In my case, Zwave JS UI tells me 1.6 when the correct version would be 1.06, thus V1.6 = V1.06 ? Really ?

Software versions

zwave-js-ui: 9.9.0.09b107a
zwave-js: 12.4.4

Device information

Observed with Home Energy Meter - Gen5 ZW095

Checklist

• I made sure to provide a driver log on level debug.

• The log includes a re-interview of the problematic device (if applicable).

• The log includes the problematic interaction with the device (if applicable).

• I provided the node ID of the problematic device (if applicable).

Upload Logfile

Just an observation after contacting Aeotec support, I have no logs.

[zwave-js-bot]

👋 Hey @duylong!

Thanks for opening an issue! It doesn't look like you provided a logfile though. While not strictly necessary for every issue, having a driver log on loglevel debug is required to diagnose most issues.

Please consider uploading a logfile that captures your problem. As a reminder, here's how to create one:

• Z-Wave JS UI
• Home Assistant Z-Wave Integration
• ioBroker.zwave2 Adapter

[AlCalzone]

Versions in Z-Wave are just 2 (major, minor) or 3 (major, minor, patch) numbers from 0-255. There is no required formatting of the numbers, e.g. leading zeros, which lead to ambiguity - why isn't 1.06 not formatted as 1.006 considering the version could go up to 1.255?

Therefore we format versions the easiest way possible by concatenating the individual parts with dots inbetween, just like SemVer. Meaning:

• Major 1, Minor 6 becomes 1.6
• Major 1, Minor 60 becomes 1.60
• Major 2, Minor 255, Patch 7 becomes 2.255.7

[duylong]

I also have this problem with Shelly, for example, I have a Shelly Qubino Wave 1 module with version 11.03 on their site but in Zwave UI, it is displayed 11.3.0. This problem is disturbing.

[josh-m-sharpe]

makes perfect sense that you would be confused by this. zwave changing things on us leads to confusion.

[josh-m-sharpe]

I get semver. I <3 semver. It's great. It'd be wonderful if all products used it everywhere.

But they don't.

Aeotec delives a firmware expressly called named "1.02" and "6.81.06"

IMO, These are the only strings that should be shown in the zwave UI. It's what the vendor called it, so it's what should be shown.
It's super confusing when I see a different version between zwave and the vendor and wonder what on earth is going on.

ZwaveJS Ui being a middleman in this situation and altering what was delivered by the vendor is an extremely confusing idea.

[josh-m-sharpe]

related: zwave-js/zwave-js-ui#3678

[josh-m-sharpe]

I'd add that a vendor releasing a version with leading zeros, to some degree, probably implies that they expect that major/minor/patch to have that many significant digits. Maybe.

In which case we'd expect these mappings:
".06" => 6
".2" => 20

and they'd be an animal if they actually released ".2" in this scheme instead of ".20"

But again, see point above about how developers are human and dork up semver all the time. All the more reason zwave shouldn't be a middleman and attempt to interpret.

[AlCalzone]

Aeotec delives a firmware expressly called named "1.02"

They call it like this in their documentation. There's no way for Z-Wave JS to know they do, since all the information we get from the stick is a number 1 (major version) and a number 2 (minor version).

Similarly, this is the information we get for the firmware version of end devices:

And this is the SDK version (which Silabs finally started formatting like SemVer does in 7.x.y):

altering what was delivered by the vendor

We alter nothing, we work with the information we've got. I'm not going to hardcode that the minor version should be zero-padded to length 2 for manufacturer A, to length 3 for manufacturer B, not at all for manufacturer C and that manufacturer D likes to convert their version numbers to roman numerals or whatever their marketing team thinks of.

---

To end this discussion: