Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features for the zulip-mobile repository. #161

Open
jackrzhang opened this issue Sep 18, 2018 · 12 comments
Open

Features for the zulip-mobile repository. #161

jackrzhang opened this issue Sep 18, 2018 · 12 comments

Comments

@jackrzhang
Copy link

Reported in chat here.

I haven't been able to add labels to issues in both the server and mobile repositories; see zulip/zulip#10500, which I opened 6 days ago, and zulip/zulip-mobile#2962, which I opened today.

@jackrzhang
Copy link
Author

@zulipbot add "bug"

@zulipbot zulipbot added the bug label Sep 18, 2018
@jackrzhang
Copy link
Author

Oh, it just worked on this repository. Hmm..

@jackrzhang
Copy link
Author

jackrzhang commented Sep 18, 2018

I just tried again to add labels to zulip/zulip-mobile#2962 (I've deleted the comment) - it still does not work there.

@synicalsyntax
Copy link
Member

@jackrzhang zulip-mobile isn't listed as an active repository in the configuration file, so all commands are ignored in that repository. I believe @borisyankov requested that we remove it from active repositories to disable issue inactivity checks.

@jackrzhang
Copy link
Author

jackrzhang commented Sep 18, 2018

Thanks for explaining! I think the actual issue I have in mind, then, is a new feature that allows for inactivity checks to be disabled for specific repositories. There's a lot of lost utility in disabling the entire bot to avoid one of the features, and I'd still like to have zulipbot enabled for the mobile repository.

I'm not very familiar with the Github API. Would something of the sort be possible? If it is, I can open a new issue for it.

@lonerz
Copy link
Member

lonerz commented Sep 18, 2018

Yea, I don't think there's currently a way to disable inactivity checks for a certain repo.

@synicalsyntax
Copy link
Member

synicalsyntax commented Sep 18, 2018

@jackrzhang Well, right now we just ignore payloads from any inactive repositories, so we can just delete those lines to continue accepting commands on those repositories. It's a two line change. Would this be acceptable?

@jackrzhang
Copy link
Author

For more context on chat.zulip.org, here's the #mobile-team topic for zulipbot.

@jackrzhang
Copy link
Author

jackrzhang commented Sep 18, 2018

@gnprice @jainkuniya

@jackrzhang jackrzhang changed the title add command does not work. Features for the zulip-mobile repository. Sep 18, 2018
@jackrzhang
Copy link
Author

jackrzhang commented Sep 18, 2018

Based on the conversation in chat, here's a tentative list of zulipbot features that are, or would be, useful for the mobile team:

  • The claim and abandon commands and the automated in progress label
  • The add and remove commands, which I try to use frequently
  • An option to disable inactivity checks, though I feel the same as @gnprice in that I'm torn on this
  • Automated size labeling - I imagine 5 categories: XS, S, M, L, XL
  • An option to disable team mentions

@synicalsyntax
Copy link
Member

Thanks for letting me know your desired settings! This fits more in of our long-term goal of refactoring the configuration system to allow creating per-repository configuration files (after we add codebase coverage), so I'm not sure how fast I can implement this. I'll be sure to update the mobile team as soon as is done though :)

@jainkuniya
Copy link
Member

Adding one more:

I will like is: when any issue is mentioned in the commit msg or PR (like Fix: #1234) then change in progess label on the issue to pr ready.

Use case:
Sometimes I am pretty much excited to review PR of some exciting issues, but i am not sure, whether PR for this issue is submitted to not (as label is still in progress). So I have to narrow to all those issues to find a PR for that issue.

(https://chat.zulip.org/#narrow/stream/243-mobile-team/subject/zulipbot/near/645150)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants