Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the "more topics" topic list component to use progressive rendering. #29666

Open
laurynmm opened this issue Apr 10, 2024 · 2 comments · May be fixed by #29872
Open

Update the "more topics" topic list component to use progressive rendering. #29666

laurynmm opened this issue Apr 10, 2024 · 2 comments · May be fixed by #29872
Labels
area: left sidebar (features) New left sidebar functionality area: performance Performance and scalability issues difficult Issues which we expect to be quite difficult

Comments

@laurynmm
Copy link
Collaborator

It's possible that for some streams, "more topics" in the left sidebar might have sufficiently many thousands of elements in it that we overfill the DOM with rendered topics as that component doesn't use the virtual list / progressing rendering system we use for the buddy list in the right sidebar.

We probably want to fix the "more topics" topic list component to use progressive rendering.

CZO thread:

I wonder if it would be possible to use that as a place to prototype using Solid, rather than spending time on fixing vdom.ts to be smarter for these likely noop rerenders, or some other high-effort approach that wouldn't make long-term progress.
@laurynmm laurynmm added the area: left sidebar (features) New left sidebar functionality label Apr 10, 2024
@ArfaNada
Copy link
Collaborator

I have checked the problem and i think I can fix it
@zulipbot claim

@zulipbot
Copy link
Member

Hello @ArfaNada!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@alya alya added area: performance Performance and scalability issues difficult Issues which we expect to be quite difficult labels Apr 10, 2024
@ArfaNada ArfaNada linked a pull request Apr 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: left sidebar (features) New left sidebar functionality area: performance Performance and scalability issues difficult Issues which we expect to be quite difficult
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize Topic List Rendering for More Topics ArfaNada/zulipFork
4 participants
@alya @zulipbot @laurynmm @ArfaNada