Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text color change on hover in typeaheads (dark theme) #29842

Closed
alya opened this issue Apr 25, 2024 · 8 comments · Fixed by #29861
Closed

Remove text color change on hover in typeaheads (dark theme) #29842

alya opened this issue Apr 25, 2024 · 8 comments · Fixed by #29861
Assignees

Comments

@alya
Copy link
Contributor

alya commented Apr 25, 2024

In typeaheads, there is a hover effect in dark theme that makes text turn blue, which does not look good. Text color should not change on hover.

CZO thread

@alya alya added bug help wanted design area: compose (typeahead) Compose typeahead content and design labels Apr 25, 2024
@zulipbot
Copy link
Member

Hello @zulip/design members, this issue was labeled with the "design" label, so you may want to check it out!

@PieterCK
Copy link
Collaborator

PieterCK commented Apr 26, 2024

Hello. I think it's because of this specific rule:
image
Deleting the color: hsl(0, 86%, 40%); on a:hover removes any color change on a tag stuff including typeaheads. Similar to hover behavior in here: https://terpimost.github.io/compose-decomposed/

image

result:
image

I'll do a bit more local testing and up a new PR for this if that's okay.

@zulipbot claim

@zulipbot
Copy link
Member

Hello @PieterCK, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@PieterCK
Copy link
Collaborator

PieterCK commented Apr 26, 2024

oh whoops, never mind. Feel free to use my findings as a reference if anyone decides to take care of this issue, hope it helps. peace 👍

@zulipbot
Copy link
Member

Hello @PieterCK, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@nimishmedatwal
Copy link
Collaborator

@zulipbot claim

@alya
Copy link
Contributor Author

alya commented Apr 27, 2024

@PieterCK you're welcome to pick up an issue if you are waiting for review on the PR you're working on. From the contributor guide, the guideline is:

I’m waiting for the next round of review on my PR. Can I pick up another issue in the meantime? Someone’s first Zulip PR often requires quite a bit of iteration, so please make sure your pull request is reviewable and go through at least one round of feedback from others before picking up a second issue. After that, sure! If Zulipbot does not allow you to claim an issue, you can post a comment describing the status of your other work on the issue you’re interested in, and asking for the issue to be assigned to you. Note that addressing feedback on in-progress PRs should always take priority over starting a new PR.

@PieterCK
Copy link
Collaborator

Thank you for informing me! I'll be more mindful of the contribution rules next time. 😃 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants