Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Feed: Improve placeholder text for empty unsubscribed stream. #29706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Message Feed: Improve placeholder text for empty unsubscribed stream. #29706

wants to merge 1 commit into from
+12 −7

Conversation

nimishmedatwal
Copy link
Collaborator

@nimishmedatwal nimishmedatwal commented Apr 12, 2024 •
edited

This pr changes the placeholder text along with fixing the style issue of subscribe button in empty unsubscribed streams.

Fixes: #29692.

Screenshots and screen captures:

Before After
image image
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: S area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) labels Apr 12, 2024
@nimishmedatwal nimishmedatwal changed the title Message Feed UI: Improve placeholder text for empty unsubscribed stream. Message Feed: Improve placeholder text for empty unsubscribed stream. Apr 12, 2024
@alya
Copy link
Contributor

alya commented Apr 12, 2024

Thanks! Looking at the screenshot, we need more vertical space above the button.

@nimishmedatwal
Copy link
Collaborator Author

@alya added the vertical space above the button.

@alya
Copy link
Contributor

alya commented Apr 13, 2024

Cool, I can test once the PR passes tests.

@nimishmedatwal nimishmedatwal force-pushed the issue#29692 branch 2 times, most recently from ca04439 to 624b7ab Compare April 13, 2024 08:42
nimishmedatwal
nimishmedatwal commented Apr 13, 2024
View reviewed changes
web/styles/zulip.css
@@ -1946,6 +1946,7 @@ nav {

.sub_button_row {
text-align: center;
margin-top: 15px;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that by this change, margin of subscribe button that toggles subscription in bookend is also affected which seemed like a desirable change to me. I am attaching screenshots for reference. Let me know if we want this change or not.

Before After
image image

@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
a968fc2 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
@alya
Copy link
Contributor

alya commented Apr 15, 2024

Yeah, that extra margin seems reasonable with the bookend as well.

@laurynmm are you up for reviewing this one? I haven't tested.

@alya alya added the maintainer review PR is ready for review by Zulip maintainers. label Apr 15, 2024
laurynmm
laurynmm reviewed Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@laurynmm laurynmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimishmedatwal - Thanks for working on this!

As you mentioned in the CZO issues thread, the state after a user clicks on the subscribe button in the empty stream is not good.

After clicking the subscribe button in the empty feed message

Screenshot from 2024-04-18 12-26-03

After clicking the unsubscribe button in the bookend

Screenshot from 2024-04-18 12-26-10

We should definitely address that problem and I can update the issue description for that as well.

I think what we'll need to do is have the bookend loaded in this view like we do when viewing an unsubscribed stream with messages. Looking at the code for loading/showing the bookend when the subscribe button in the empty narrow is clicked would probably be a good place to start for working out how to do that when the user is initially viewing the unsubscribed stream.

And then for the empty banner, we can just show the default message for this case.

@zulipbot
Copy link
Member

Heads up @nimishmedatwal, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurynmm laurynmm laurynmm left review comments

Assignees
No one assigned
Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) has conflicts maintainer review PR is ready for review by Zulip maintainers. size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve empty message views in unsubscribed streams
4 participants
@nimishmedatwal @alya @zulipbot @laurynmm