Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACKING: Event handling improvements #993

Open
2 of 15 tasks
Ezio-Sarthak opened this issue Apr 12, 2021 · 6 comments
Open
2 of 15 tasks

TRACKING: Event handling improvements #993

Ezio-Sarthak opened this issue Apr 12, 2021 · 6 comments
Labels
area: event handling How events from the server are responded to GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: admin A missing feature *for admins*, present in another Zulip client missing feature: user A missing feature for all users, present in another Zulip client TRACKING

Comments

@Ezio-Sarthak
Copy link
Member

Ezio-Sarthak commented Apr 12, 2021

ZT currently handles some common (e.g., message/subscription update) events. To know more about events API, check out the Get events doc :)

Below are some events that might be a good addition:

Despite the above events there are some which might not need attention as of now, however, would be worth mentioning:

  • has_zoom_token: Zoom integration (OAuth flow required)
  • invites_changed: Event sent to Admin if the set of invitations change
  • default_stream_groups: Handling change of default user groups (experimental, not stabilized)
  • hotspots: Sent when set of onboarding "hotspots" (for current user) has changed. Might be a potential follow-up of tutorial experience.
  • realm_filters/realm_linkifiers: Handle a change of configured linkifiers. (See Migrate from realm_filters event format to new realm_linkifiers format #995 for handling new format events and supporting backwards compatibility).
  • realm_domains: Handles change for the set of allowed domains for new users. Might be fruitful after improving support for multiple organizations.
  • realm_export: Event sent to users requesting a data export.
  • realm_bot: Event responsible to let user administer a newly created bot (see also realm_user).
@zulipbot
Copy link
Member

ERROR: Label "area:event handling" does not exist and was thus not added to this issue.

@Ezio-Sarthak
Copy link
Member Author

@zulipbot add "area: event handling"

@zulipbot zulipbot added the area: event handling How events from the server are responded to label Apr 12, 2021
@neiljp neiljp added the GSoC Possible GSoC project component label Apr 12, 2021
@neiljp
Copy link
Collaborator

neiljp commented Apr 12, 2021

Tagged with GSoC, but this is across multiple areas so as per the tracking nature of this issue, this isn't something one person will likely work on.

@abhijeetbodas2001
Copy link
Member

realm_filters: Handle a change of configured linkifiers.

I get that this is not a high priority, but whenever in the future ZT adds support for handling events sent after the linkifiers in the realm have changed, we should handle the new realm_linkifiers events, since the realm_filters event type has been deprecated in feature level 54. #995 has more context. Can you update the issue description?

@Ezio-Sarthak
Copy link
Member Author

Thanks! Updated the issue description :)

zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 6, 2021
This adds a new event action in model that looks for delete_message
events, potentially handling it by removing the message completely
from the index, and then updates the rendered_view to handle the
event dynamically without needing to switch narrows. It also looks
out for messages being unread before being deleted and updates the
count appropriately. The tests are still missing which will be added
in the next iteration of this commit.

Fixes one check-box of zulip#993.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 6, 2021
This adds a new event action in model that looks for delete_message
events, potentially handling it by removing the message completely
from the index, and then updates the rendered_view to handle the
event dynamically without needing to switch narrows. It also looks
out for messages being unread before being deleted and updates the
count appropriately. The tests are still missing which will be added
in the next iteration of this commit.

Fixes one check-box of zulip#993.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 6, 2021
This adds a new event action in model that looks for delete_message
events, potentially handling it by removing the message completely
from the index, and then updates the rendered_view to handle the
event dynamically without needing to switch narrows. It also looks
out for messages being unread before being deleted and updates the
count appropriately. The tests are still missing which will be added
in the next iteration of this commit.

Fixes one check-box of zulip#993.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 7, 2021
This adds a new event action in model that looks for delete_message
events, potentially handling it by removing the message completely
from the index, and then updates the rendered_view to handle the
event dynamically without needing to switch narrows. It also looks
out for messages being unread before being deleted and updates the
count appropriately. The tests are still missing which will be added
in the next iteration of this commit.

Fixes one check-box of zulip#993.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 7, 2021
This adds a new event action in model that looks for delete_message
events, potentially handling it by removing the message completely
from the index, and then updates the rendered_view to handle the
event dynamically without needing to switch narrows. It also looks
out for messages being unread before being deleted and updates the
count appropriately. The tests are still missing which will be added
in the next iteration of this commit.

Fixes one check-box of zulip#993.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 8, 2021
This adds a new event action in model that looks for delete_message
events, potentially handling it by removing the message completely
from the index, and then updates the rendered_view to handle the
event dynamically without needing to switch narrows. It also looks
out for messages being unread before being deleted and updates the
count appropriately.

Tests added.
Fixes one check-box of zulip#993.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 9, 2021
This commit extends the previous commit that added rudimentary
support for handling delete_message event, and allows updating the
special narrows such as mentioned/starred that were depending on
message flags. This commit could be considered as a bugfix over the
previous one. It also handles updating the unread count if the
message was earlier unread before being deleted.

Tests added and amended.
Fixes one check-box in zulip#993.
@neiljp neiljp pinned this issue Mar 14, 2022
@neiljp neiljp added the high priority should be done as soon as possible label Mar 14, 2022
@neiljp neiljp added missing feature: admin A missing feature *for admins*, present in another Zulip client missing feature: user A missing feature for all users, present in another Zulip client labels May 16, 2022
@neiljp
Copy link
Collaborator

neiljp commented Oct 6, 2022

Also see zulip/zulip-mobile#3408 for a similar mobile tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: event handling How events from the server are responded to GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: admin A missing feature *for admins*, present in another Zulip client missing feature: user A missing feature for all users, present in another Zulip client TRACKING
Projects
None yet
Development

No branches or pull requests

4 participants