New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of pressing Esc
during message compose
#1342
Comments
Hello @zulip/server-hotkeys members, this issue was labeled with the "area: hotkeys" label, so you may want to check it out! |
@zulipbot claim |
Fixes zulip#1342 If length of text in msg compose box > 10, then only show confirmation popup.
@srdeotarse You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
@zulipbot claim |
I am working on this issue. |
@zulipbot claim |
@rsashank You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
Fixes zulip#1342. Introduces variable CONFIRMATION_MSG_LENGTH to set how many characters are required in compose box to prompt a popup instead of the current instant exit when Esc is pressed.
I would like to work on this |
@zulipbot claim |
Welcome to Zulip, @enock-arthur! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
Hello @enock-arthur, |
Introduces variable MAX_MESSAGE_LENGTH_CONFIRMATION_POPUP to set a threshold for maximum length of message in compose box beyond which it prompts a confirmation popup instead of the current instant exit when Esc is pressed. Fixes zulip#1342.
Introduces variable MAX_MESSAGE_LENGTH_CONFIRMATION_POPUP to set a threshold for maximum length of message in compose box beyond which it prompts a confirmation popup instead of the current instant exit when Esc is pressed. Fixes zulip#1342.
Introduces variable MAX_MESSAGE_LENGTH_CONFIRMATION_POPUP to set a threshold for maximum length of message in compose box beyond which it prompts a confirmation popup instead of the current instant exit when Esc is pressed. Fixes zulip#1342.
Introduces variable MAX_MESSAGE_LENGTH_CONFIRMATION_POPUP to set a threshold for maximum length of message in compose box beyond which it prompts a confirmation popup instead of the current instant exit when Esc is pressed. Fixes zulip#1342.
Introduces variable MAX_MESSAGE_LENGTH_CONFIRMATION_POPUP to set a threshold for maximum length of message in compose box beyond which it prompts a confirmation popup instead of the current instant exit when Esc is pressed. Fixes zulip#1342.
Currently
Esc
can be pressed to exit compose, without sending the message.This can be useful if one wants to cancel the send, but can also be frustrating if accidentally hitting the key after having written a good message which you intend to send.
This can be made worse, if a key is near the
Esc
key and used for composition, eg. the ` key for inline code or quote/code blocks.Ideas for resolving this:
Please discuss this in the stream before proceeding with this, since it would be good to get more views on this first.
The text was updated successfully, but these errors were encountered: