Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Private Messages side panel #1197

Open
neiljp opened this issue Apr 13, 2022 · 6 comments · May be fixed by #1416
Open

Add Private Messages side panel #1197

neiljp opened this issue Apr 13, 2022 · 6 comments · May be fixed by #1416
Labels
area: UI General user interface update GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client version parity: <=2.1
Milestone

Comments

@neiljp
Copy link
Collaborator

neiljp commented Apr 13, 2022

This feature would provide the equivalent functionality to the web-app where clicking on the private messages button opens a drop-down.

However, in our case it seems cleaner (certainly as a first step) to integrate this as an alternative side panel to the streams/topics area. In this situation we likely need to add a key to switch back to the streams list, so may likely take over S for this purpose.

This issue comprises multiple steps, which could be resolved in one PR but may be more appropriate to merge over multiple PRs or cherry-picking commits from the one PR.

Possible steps:

  • Add Stream messages total in top left; the web app does not have this, but this provides a great location to position a S (or similar) key when the PM side panel feature is fully added. This would need to handle the same intricacies as other totals in terms of muted elements.
  • Generate a similar widget to the stream panel with a list of recent conversations with unread totals; buttons in that panel would load conversations a little like from the user list but without opening compose and would also need to cope with group PMs (see Implement buddy list like in zulip-mobile. #220/Views/BuddyView: Introduce BuddyView to show Recent PMs and Group PMs. #315)
  • Switch to that widget when pressing P (shift p), NOT narrowing to PMs and focusing on a message; at the same time enable S (shift s) for showing the stream list

There are various nuances to consider, such as preserving state in lists between toggling, whether we consider stream+topic as a state (ie. S returns to topic list if previously in it)

Possible followup would be to enable the p key for what I believe we currently do for P (needs checking), ie. go to next unread PM. That would involve focusing on the message list, rather than switching the left panel. We could also consider using s for 'next unread stream message' and enable a 'streams narrow' (no PMs). This is similar but subtly different to the existing n key (for next unread topic), a feature which needs a little fine tuning eg. #442. Except for perhaps the first of these, these follow-ups would definitely benefit from further discussion.

I most recently proposed this feature in #zulip-terminal > Streams/PMs view toggle #T1197, where discussion may continue.

@neiljp neiljp added area: UI General user interface update GSoC Possible GSoC project component missing feature: user A missing feature for all users, present in another Zulip client labels Apr 13, 2022
@neiljp neiljp added this to the Release after next milestone Apr 13, 2022
@plugyawn
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @plugyawn, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@plugyawn
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @plugyawn!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@plugyawn
Copy link
Collaborator

plugyawn commented Jul 4, 2022

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jul 4, 2022

Hello @plugyawn!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update GSoC Possible GSoC project component high priority should be done as soon as possible missing feature: user A missing feature for all users, present in another Zulip client version parity: <=2.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants