Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRACKING: Migrate internal code to use Direct Message terminology #1344

Open
neiljp opened this issue Mar 21, 2023 · 26 comments · May be fixed by #1406
Open

TRACKING: Migrate internal code to use Direct Message terminology #1344

neiljp opened this issue Mar 21, 2023 · 26 comments · May be fixed by #1406
Labels
api migrations area: refactoring help wanted This issue should be clear enough to work on TRACKING

Comments

@neiljp
Copy link
Collaborator

neiljp commented Mar 21, 2023

This is a follow-up to the user-visible #1288, as fixed by #1322.

  • Rename/clarify internal variables; we could dedicate a specific task to this, but it may be more effective to migrate as-needed, where one part of the code is changed at a time, which relates to a particular other change underway
  • Update to follow API changes; these will likely not be rapid, and support the older API for some time in any case
@zulipbot
Copy link
Member

Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!

@abdulmoiz37
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @abdulmoiz37!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@abdulmoiz37
Copy link
Collaborator

@zulipbot add "help wanted"

@zulipbot zulipbot added the help wanted This issue should be clear enough to work on label Apr 10, 2023
@abdulmoiz37
Copy link
Collaborator

abdulmoiz37 commented Apr 10, 2023

@zulipbot claim

@zulipbot
Copy link
Member

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

1 similar comment
@zulipbot
Copy link
Member

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@abdulmoiz37
Copy link
Collaborator

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@zulipbot I would like to work on this issue as well till my other PR's get reviewed.can you assign this to me?

@abdulmoiz37
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@neiljp
Copy link
Collaborator Author

neiljp commented Apr 17, 2023

@abdulmoiz37 You are welcome to work on this, but it's not a high priority compared to other areas.

As the summary aims to suggest, this may be better achieved by migrating naming when we work on particular areas, one at a time.

@zulipbot
Copy link
Member

zulipbot commented May 4, 2023

Hello @WladRamos, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

1 similar comment
@zulipbot
Copy link
Member

zulipbot commented May 4, 2023

Hello @WladRamos, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@mschuler10
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented May 4, 2023

Welcome to Zulip, @mschuler10! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented May 15, 2023

@PedroQXD You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@mschuler10
Copy link
Collaborator

@zulipbot abandon

@PedroQXD
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @PedroQXD! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@PedroQXD
Copy link
Collaborator

Hello @neiljp , I was looking into this issue and I have a question. The issue description specifies that only the internal variables need to be renamed, but for this change, I believe it makes sense to also modify the methods headers. How should I proceed?

@PedroQXD
Copy link
Collaborator

@zulipbot claim

@PedroQXD
Copy link
Collaborator

@zulipbot abandon

@WladRamos
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

ERROR: Unexpected response from GitHub API.

@WladRamos
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jun 11, 2023

@WladRamos You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api migrations area: refactoring help wanted This issue should be clear enough to work on TRACKING
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants