Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Messages top area when in topic & direct message narrows #1343

Open
neiljp opened this issue Mar 21, 2023 · 5 comments
Open

Adjust Messages top area when in topic & direct message narrows #1343

neiljp opened this issue Mar 21, 2023 · 5 comments
Labels
area: UI General user interface update enhancement New feature or request help wanted This issue should be clear enough to work on

Comments

@neiljp
Copy link
Collaborator

neiljp commented Mar 21, 2023

When in a topic narrow or a direct message narrow (with specific users, not all direct messages), it would be beneficial to hide the 'Current message recipients' line and content in the line below it.

While in such narrows:

  • the content in that line never changes while within the narrow
  • the content currently shown in the line above isn't clear/necessary/distinct
    • eg. 'zulip-terminal: topic narrow' with 'zulip-terminal > some topic' beneath it
    • eg. 'Group private conversation' with 'You and [list of user names]' beneath it

To resolve this, when in such a narrow, it would be clearer to

  • not show the 'Current message recipients' and the line below
  • replace the text we currently have in the top (before the search) by the text that is currently in that line below

In other narrows we should retain the current behavior.

Implementing this could be simple or challenging. A quick exploration may be simple, but adding/updating tests may be difficult due to the way the UI widgets are currently laid out.

Sketching this out, this could look like:

Direct message narrow:

----------------- Messages ---------------
You and user 1, user 2  Search [/]:
------------------------------------------

Topic narrow:

----------------- Messages ---------------
zulip-terminal > some topic  Search [/]:
------------------------------------------

Stream narrow:

----------------- Messages ---------------
zulip-terminal  Search [/]:
------- Current message recipients -------
zulip-terminal > some current topic
------------------------------------------

All Direct messages narrow:

----------------- Messages ---------------
All direct messages  Search [/]:
------- Current message recipients -------
You and user1
------------------------------------------
@neiljp neiljp added enhancement New feature or request help wanted This issue should be clear enough to work on area: UI General user interface update labels Mar 21, 2023
@srdeotarse
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 8, 2023

@srdeotarse You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@rsashank
Copy link
Member

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Dec 23, 2023

@rsashank You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@Niloth-p
Copy link
Collaborator

Related: #1016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update enhancement New feature or request help wanted This issue should be clear enough to work on
Projects
None yet
Development

No branches or pull requests

5 participants