Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task idea: Use test helpers instead of hard-coding emails or calling get_user #618

Open
hackerkid opened this issue Nov 18, 2017 · 0 comments

Comments

@hackerkid
Copy link
Member

  • We trying to not hard code email address in tests. Instead of that we would use self.example_email, or self.mit_email or self.nonreg_email.
    eg: instead of iago@zulip.com we use self.example_email("iago")
  • We also avoid calling get_user function in tests. Instead of that we use self.example_user or self.mit_user, self.nonreg_user or self.notification_bot.
@hackerkid hackerkid changed the title task idea: Use self.example_user and self.example_email in tests task idea: Use test helpers instead of hard-coding emails as well as calling get_user Nov 18, 2017
@hackerkid hackerkid changed the title task idea: Use test helpers instead of hard-coding emails as well as calling get_user task idea: Use test helpers instead of hard-coding emails or calling get_user Nov 18, 2017
@Lyla-Fischer Lyla-Fischer added this to Idea in Task Creation Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Task Creation
  
Idea
Development

No branches or pull requests

1 participant