Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task idea: Remove unused imports from files #617

Open
hackerkid opened this issue Nov 18, 2017 · 3 comments
Open

task idea: Remove unused imports from files #617

hackerkid opened this issue Nov 18, 2017 · 3 comments

Comments

@hackerkid
Copy link
Member

We have a lot of unused import in many python files. Removing them can be a task.

@rht
Copy link

rht commented Nov 19, 2017

This had been finished in zulip/zulip#7262 actually. I ran flake8 and grepped for F401, while making sure that the ones needed by type annotation (in Python 2 syntax) are still imported.

@timabbott
Copy link
Sponsor Member

@rht did that actually cover the whole codebase? I would have thought it's only done for the parts of the codebase that we've moved to the Python 3 type syntax...

@rht
Copy link

rht commented Nov 21, 2017

Yup, I updated the statement here: zulip/zulip#7262 (comment). This can be quickly re-verified later anyway once the full mypy comments to annotations migration has been completed.

@Lyla-Fischer Lyla-Fischer added this to Idea in Task Creation Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Task Creation
  
Idea
Development

No branches or pull requests

3 participants