Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web auth sometimes fails #620

Closed
gnprice opened this issue Apr 5, 2024 · 1 comment · Fixed by #639
Closed

Web auth sometimes fails #620

gnprice opened this issue Apr 5, 2024 · 1 comment · Fixed by #639
Assignees
@chrisbobbe
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-first-hour Issues specific to using the app for the first time a-login beta feedback Things beta users have specifically asked for
Milestone
Beta 2

Comments

@gnprice
Copy link
Member

gnprice commented Apr 5, 2024

See detailed report in chat.

Some potentially key details include:

  • This was on Android.
  • The browser which powered the webview was Firefox for Android.
  • After redirecting to the app:

    When I am sent back to the app, it just shows the main "Choose account"//"Add an account" page. There is no error message
@gnprice gnprice added a-Android Issues specific to Android, or requiring Android-specific work a-login a-first-hour Issues specific to using the app for the first time beta feedback Things beta users have specifically asked for labels Apr 5, 2024
@gnprice gnprice added this to the Beta 2 milestone Apr 5, 2024
@chrisbobbe
Copy link
Collaborator

Responded in the linked chat thread with some thoughts, including a potential solution that I want to check with Greg when he's back from vacation.

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Apr 30, 2024
@chrisbobbe
android: Set launchMode="singleTask" instead of "singleTop"
380df7d 
This addresses zulip#620 by making it so the whole app state isn't reset
when coming back from Firefox in the web-auth flow. Discussion:
  https://chat.zulip.org/#narrow/stream/48-mobile/topic/Flutter.20app.20.2B.20SAML.20auth/near/1776828

Later in that discussion, Greg found that this mode is the most
appropriate for our app, and that setting taskAffinity="" is
probably a good idea as a security-hardening measure.

Fixes: zulip#620
@chrisbobbe chrisbobbe mentioned this issue Apr 30, 2024
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 2, 2024
@chrisbobbe
android: Set launchMode="singleTask" instead of "singleTop"
1e9a27d 
This addresses zulip#620 by making it so the whole app state isn't reset
when coming back from Firefox in the web-auth flow. Discussion:
  https://chat.zulip.org/#narrow/stream/48-mobile/topic/Flutter.20app.20.2B.20SAML.20auth/near/1776828
Later in that discussion, Greg found that this mode is the most
appropriate for our app.

Fixes: zulip#620
@gnprice gnprice closed this as completed in 1135860 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-Android Issues specific to Android, or requiring Android-specific work a-first-hour Issues specific to using the app for the first time a-login beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: Done
Milestone
Beta 2
Development

Successfully merging a pull request may close this issue.

android: Set launchMode="singleTask" instead of "singleTop" chrisbobbe/zulip-flutter
2 participants
@gnprice @chrisbobbe