Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star icon too high on messages #616

Open
gnprice opened this issue Apr 3, 2024 · 0 comments · May be fixed by #651
Open

Star icon too high on messages #616

gnprice opened this issue Apr 3, 2024 · 0 comments · May be fixed by #651
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for

Comments

@gnprice
Copy link
Member

gnprice commented Apr 3, 2024

In the message list, when a message is starred, the star icon appears too high relative to the message text:
image

See chat thread for discussion.

Instead, the "shoulders" of the star (the near-horizontal top edges of the left and right wedges of the star) should be at about the x-height of the first line of text, i.e. about the same height as the top of letters like "x" and "e". Like this (from this PR subthread):
image

@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-design Visual and UX design beta feedback Things beta users have specifically asked for labels Apr 3, 2024
@gnprice gnprice added this to the Beta 2 milestone Apr 3, 2024
@Syrineladeb02 Syrineladeb02 linked a pull request May 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for
Projects
Status: No status
1 participant