Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Option to set default overall zoom for all servers (and minor setting zoom incrementally bug) #1360

Open
nuke-web3 opened this issue Mar 15, 2024 · 2 comments

Comments

@nuke-web3
Copy link

nuke-web3 commented Mar 15, 2024

Problem Description

The zoom level set with the view menu or crtl+<=/-> is configurable per-server, and this is sticky for each instance. One would usually want all app windows to use the same zoom level that would be a global default setting.

Proposed Solution

Ideally one would have a menu option to set the default zoom level for all servers. Most browsers support this kinda thing and it seems there are ways to expose this in electron.

Example from the desktop telegram app:

image

The server could remember and override the default setting, using keybindings or perhaps a server level setting (rather than app level)

@andersk
Copy link
Member

andersk commented Mar 21, 2024

I cannot reproduce your first problem. The per-domain zoom level is remembered across restart for me.

There is a minor bug where the zoom is reset to 100% the first time you change it, though.

(The setZoomFactor API is what we’re using; Chromium takes care of remembering it per-domain.)

@nuke-web3
Copy link
Author

Ah indeed, I cannot seem to reproduce the restart reset of the zoom. I do see the same issue with jump to 100% on any change.

I will change the title & OP to reflect the minor bug & request to have a global setting to default to, as it's a minor UX nuisance to have them independently configured (unless you for some reason explicitly want that as an override)

@nuke-web3 nuke-web3 changed the title [Feat] Remember the zoom level used per server between app restarts (plus option to set default overall zoom for all servers) [Feat] Option to set default overall zoom for all servers (and minor setting zoom incrementally bug) Mar 21, 2024
andersk added a commit that referenced this issue Mar 21, 2024
This matches the native Electron behavior.

Fixes part of #1360 by removing the separate zoomFactor state
variable.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants