Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add organization: url: attempt to autocomplete with zulipchat.com #1012

Open
jtagcat opened this issue Aug 6, 2020 · 20 comments · May be fixed by #1043 or #1204
Open

add organization: url: attempt to autocomplete with zulipchat.com #1012

jtagcat opened this issue Aug 6, 2020 · 20 comments · May be fixed by #1043 or #1204

Comments

@jtagcat
Copy link

jtagcat commented Aug 6, 2020

Problem Description
image

Expected: overnode.zulipchat.org

Proposed Solution
If the entered string does:

  • match the organization url conditions (Subdomain can only have lowercase letters, numbers, and dashes.)
    • (including) doesn't start with a protocol (https://overnode should still work)
    • (including) doesn't contain any dots, aka any TLDs.

If the URL will be autocompleted, Show that within the text box (with grey text?).

Describe alternatives you've considered
Give the user a first time impression of ERROR?

I might attempt to close this myself within tommorow - 3 months

@JulianGro
Copy link

The android app already does this. Just FYI.

@timabbott
Copy link
Sponsor Member

timabbott commented Sep 22, 2020

Thanks for the feedback! Yeah, I'd like to see this changed in the desktop app as well. We should be smart about the UX details around this though -- we want to make it very clear what URL users will be connecting to if they submit the form. One possible option would be to have two text boxes, with the top one being https://_____.zulipchat.com.

(I don't think the Android app's exact implementation on this is particularly good)

@akashnimare
Copy link
Member

It make sense to autocomplete the url in the mobile app but in the desktop app, we should try to keep it as simple as possible. Don't need to add too much autocompletion and all. I think having two views (Self-hosted, zulipchat.com) would make sense here.

@jtagcat
Copy link
Author

jtagcat commented Sep 23, 2020

UX? One box, if the current text input matches the conditions, show <input placeholder=".zulipchat.com">-like thing, grey text at the right of the text input.

@timabbott
Copy link
Sponsor Member

Yeah, I think that's better. We can assume https unless the URL starts with http:// (support for which is mainly for testing with the development environment).

@abhigyank
Copy link
Collaborator

I think some selfhosted folks could have something like http://zulip defined for their internal network. In those cases it would break for them. The solution for that would be to have two input boxes. Perrsonally I feel it maybe confusing/bad UX.

@jtagcat
Copy link
Author

jtagcat commented Sep 24, 2020

As I mentioned before:
hosted → https://hosted.zulipchat.com
http://hostedhttp://hosted
https://hostedhttps://hosted

With http, you would need to type http:// anyways, as we can default to https://. I don't see the problem here.
Adding the gray .zulipchat.com appended when no protocol is found, and the instance name is compatible with the naming rules makes it even more clear?

How is this exactly handled in the mobile app? Did we miss something?

@timabbott
Copy link
Sponsor Member

Yeah, @jtagcat's comment reflects what I had in mind; I believe that's the algorithm the mobile app uses at a high level.

@gnprice FYI.

aryanshridhar added a commit to aryanshridhar/zulip-desktop that referenced this issue Nov 18, 2020
Autocompletes when the user passes only org url,
in the server url input.

Fixes zulip#1012
@aryanshridhar aryanshridhar linked a pull request Nov 18, 2020 that will close this issue
3 tasks
@Signior-X
Copy link
Member

Signior-X commented Dec 21, 2020

Are you still working on this? @aryanshridhar
or should I take it forward.

@aryanshridhar
Copy link
Member

Hey @Signior-X , I have already added the necessary changes within #1043 . Would be great if you could address something which I accidentally left out .

@SidharajYadav

This comment has been minimized.

@SidharajYadav

This comment has been minimized.

@andersk

This comment has been minimized.

@manila
Copy link
Collaborator

manila commented Apr 16, 2022

Any chance I could take this a little further? I built off of #1043 and added a UX similar to the one's found in the mobile apps

Here is what it could look like:

zulip-desktop-autofill

let me know and I'll make a new PR for this issue

@manila
Copy link
Collaborator

manila commented Apr 18, 2022

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @manila! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

manila pushed a commit to manila/zulip-desktop that referenced this issue Apr 19, 2022
Autocompletes when the user passes only org url,
in the server url input.

Fixes zulip#1012
manila added a commit to manila/zulip-desktop that referenced this issue Apr 19, 2022
manila added a commit to manila/zulip-desktop that referenced this issue Apr 19, 2022
@manila manila linked a pull request Apr 19, 2022 that will close this issue
3 tasks
@zulipbot
Copy link
Member

@manila We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick @zulipbot abandon comment so that someone else can claim this issue and continue from where you left off.

If we don't hear back, you will be automatically unassigned in 4 days. Thanks!

@manila
Copy link
Collaborator

manila commented Apr 29, 2022

It looks like this could still be up for discussion so I'll remove myself from this issue. There is likely a better solution for this, and if this continues to remain open I may take another shot at it :)

@manila
Copy link
Collaborator

manila commented Apr 29, 2022

@zulipbot abandon

manila pushed a commit to manila/zulip-desktop that referenced this issue May 6, 2022
Autocompletes when the user passes only org url,
in the server url input.

Fixes zulip#1012
manila added a commit to manila/zulip-desktop that referenced this issue May 6, 2022
manila added a commit to manila/zulip-desktop that referenced this issue May 6, 2022
Autocompletes when the user passes only org url,
in the server url input.

Fixes zulip#1012
manila added a commit to manila/zulip-desktop that referenced this issue May 6, 2022
manila pushed a commit to manila/zulip-desktop that referenced this issue May 6, 2022
Autocompletes when the user passes only org url,
in the server url input.

Fixes zulip#1012
manila added a commit to manila/zulip-desktop that referenced this issue May 6, 2022
manila added a commit to manila/zulip-desktop that referenced this issue May 6, 2022
@iSatVeerSingh
Copy link

is this issue still unresolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet