Remove use of removed !avatar syntax from API bots #632

timabbott · 2020-11-07T00:00:11Z

Apparently, we have a few integrations that are using the !avatar markdown syntax that we removed some time ago:

tabbott@coset:~/python-zulip-api$ git grep '!avatar'
zulip/integrations/git/post-receive:            commits += '!avatar(%s) %s\n' % (author_email, subject)
zulip/integrations/git/zulip_git_config.py:# return '!avatar(%s) [%s](https://example.com/commits/%s)\n' % (author, subject, commit_id)
zulip/integrations/git/zulip_git_config.py:    return '!avatar(%s) %s\n' % (author, subject)
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:            'quit', 'Game cancelled.\n!avatar(foo@example.com) **foo** quit.', 0, bot, 'foo')
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:        self.verify_response('move 3', '**foo** moved in column 3\n\nfoo\n\n!avatar(baz@example.com) It\'s **baz**\'s (:red_circle:) turn.',
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:        self.verify_response('move 3', '**baz** moved in column 3\n\nfoo\n\n!avatar(foo@example.com) It\'s **foo**\'s (:blue_circle:) turn.',
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:        self.verify_response('move 5', '!avatar(foo@example.com) It\'s **foo**\'s (:blue_circle:) turn.', 0,
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:            self.verify_response('move 3', '!avatar(foo@example.com) **foo** won! :tada:',
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:            self.verify_response('move 3', '!avatar(foo@example.com) **foo** won! :tada:',
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:        self.verify_response('move 3', '**foo** moved in column 3\n\nfoo\n\n!avatar(test-bot@example.com) It\'s **test-bot**\'s (:red_circle:) turn.',
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:> !avatar(foo@example.com)\n\
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:> !avatar(foo@example.com)
zulip_bots/zulip_bots/bots/game_handler_bot/test_game_handler_bot.py:> !avatar(bar@example.com)
zulip_bots/zulip_bots/game_handler.py:        sender_avatar = "!avatar({})".format(sender)
zulip_bots/zulip_bots/game_handler.py:        player_avatar = "!avatar({})".format(player_email)
zulip_bots/zulip_bots/game_handler.py:                user_turn_avatar = "!avatar({})".format(self.players[self.turn])
zulip_bots/zulip_bots/game_handler.py:        user_turn_avatar = "!avatar({})".format(self.players[self.turn])
zulip_bots/zulip_bots/game_handler.py:            user_turn_avatar = "!avatar({})".format(self.players[self.turn])
zulip_bots/zulip_bots/game_handler.py:            winner_avatar = "!avatar({})".format(winner)

The Git integration is the most important; we should migrate it to use the same formatting model we have for the GitHub/GitLab integrations in the webapp.

For the game handler, I suspect we want to just switch to using names, but if that's problematic, we could consider adding a new "show user avatar" syntax that is more HTML-like, e.g. an <avatar> tag.

The text was updated successfully, but these errors were encountered:

RioAtHome · 2020-11-25T01:48:41Z

@zulipbot claim

m-e-l-u-h-a-n · 2020-12-06T10:11:19Z

@mateuszmandera how can I know about formatting model for github/gitlab integrations, in order perfrom this migration for Git integration.
Also can I work on this issue...

RioAtHome · 2020-12-07T17:16:42Z

@m-e-l-u-h-a-n hey, i kinda gave up on it from not knowing where to find the github integration, but if you want to work on it, maybe check zulip main repository, and find the webhooks for github/gitlabs, they might have the desired formatting, im not an expert on this , so take what i said with a grain of salt, goodluck!

m-e-l-u-h-a-n · 2020-12-08T07:14:36Z

Thanks! @R0cker77, for suggestion will try my best!

vinitwadgaonkar · 2021-01-02T15:20:49Z

@zulipbot claim

zulipbot · 2021-01-02T15:20:51Z

Welcome to Zulip, @vinitwadgaonkar! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

vinitwadgaonkar · 2021-01-04T09:15:42Z

can anybody please brief me little what exactly is needed to be done in this issue

vinitwadgaonkar · 2021-01-04T09:16:11Z

am i supposed to replace !avatar expression with its html tag

vinitwadgaonkar · 2021-01-04T10:30:07Z

zulipbot

vinitwadgaonkar · 2021-01-04T10:30:18Z

@zulipbot

vinitwadgaonkar · 2021-01-04T10:30:41Z

@zulipbot pull request

vinitwadgaonkar · 2021-01-07T03:17:57Z

please review and merge following pull request for this issue:
#642
#641

vinitwadgaonkar · 2021-01-17T13:52:07Z

please review and merge following pull request for this issue:
#P642
#P641

@neiljp @timabbott sir please review

RioAtHome · 2021-01-17T22:22:23Z

Hey @vinitwadgaonkar, you should check the Zulip community, to discuss the issues that your having, and getting code reviews. in general the community have a better respond time.

ahmedabuamra · 2021-02-03T21:50:30Z

@zulipbot claim

zulipbot · 2021-02-03T21:50:33Z

Welcome to Zulip, @ahmedabuamra! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

The issue linked to this commit suggest suggests to replace the avatar with the username only, I just needed to remove !avatar as the code already shows username. Fixes: zulip#632

…ead. Getting the logs run in cmd as in function `git_commit_range(oldrev, newrev)` so I had to prefix author name with -[AUTHOR], commit with -[COMMIT] and subject/title with -[SUBJECT] to be able to extract these info correctly. I also tried to stick with the format proposed in this issue zulip/zulip#3968 except for showing the author's name before each commit and without summary. Fixes: zulip#632

The issue linked to this commit suggest suggests to replace the avatar with the username only, I just needed to remove !avatar as the code already shows the username. Fixes part of #632.

zulipbot · 2021-03-07T01:02:29Z

Hello @ahmedabuamra, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

gvarun1 · 2021-06-15T16:34:25Z

@zulipbot claim

zulipbot · 2021-06-15T16:34:29Z

Hello @gvarun1, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

gvarun1 · 2021-06-15T16:34:45Z

@zulipbot claim

zulipbot · 2021-06-15T16:34:49Z

Hello @gvarun1, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot · 2021-06-15T16:35:21Z

Hello @gvarun1, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

timabbott added help wanted priority: high good first issue labels Nov 7, 2020

mateuszmandera mentioned this issue Nov 14, 2020

Remove use of removed !avatar syntax from inte #631

Closed

zulipbot assigned vinitwadgaonkar Jan 2, 2021

zulipbot added the in progress label Jan 2, 2021

This was referenced Jan 4, 2021

Update test_game_handler_bot.py #642

Closed

Update game_handler.py #641

Closed

vinitwadgaonkar removed their assignment Jan 27, 2021

zulipbot removed the in progress label Jan 27, 2021

zulipbot assigned ahmedabuamra Feb 3, 2021

zulipbot added the in progress label Feb 3, 2021

ahmedabuamra linked a pull request Feb 5, 2021 that will close this issue

integrations: Remove !avatar from git and game handler. #649

Open

zulipbot unassigned ahmedabuamra Mar 11, 2021

zulipbot removed the in progress label Mar 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove use of removed !avatar syntax from API bots #632

Remove use of removed !avatar syntax from API bots #632

timabbott commented Nov 7, 2020

RioAtHome commented Nov 25, 2020

m-e-l-u-h-a-n commented Dec 6, 2020

RioAtHome commented Dec 7, 2020

m-e-l-u-h-a-n commented Dec 8, 2020

vinitwadgaonkar commented Jan 2, 2021

zulipbot commented Jan 2, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 7, 2021

vinitwadgaonkar commented Jan 17, 2021 •

edited

RioAtHome commented Jan 17, 2021

ahmedabuamra commented Feb 3, 2021

zulipbot commented Feb 3, 2021

zulipbot commented Mar 7, 2021

gvarun1 commented Jun 15, 2021

zulipbot commented Jun 15, 2021

gvarun1 commented Jun 15, 2021

zulipbot commented Jun 15, 2021

zulipbot commented Jun 15, 2021

Remove use of removed !avatar syntax from API bots #632

Remove use of removed !avatar syntax from API bots #632

Comments

timabbott commented Nov 7, 2020

RioAtHome commented Nov 25, 2020

m-e-l-u-h-a-n commented Dec 6, 2020

RioAtHome commented Dec 7, 2020

m-e-l-u-h-a-n commented Dec 8, 2020

vinitwadgaonkar commented Jan 2, 2021

zulipbot commented Jan 2, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 4, 2021

vinitwadgaonkar commented Jan 7, 2021

vinitwadgaonkar commented Jan 17, 2021 • edited

RioAtHome commented Jan 17, 2021

ahmedabuamra commented Feb 3, 2021

zulipbot commented Feb 3, 2021

zulipbot commented Mar 7, 2021

gvarun1 commented Jun 15, 2021

zulipbot commented Jun 15, 2021

gvarun1 commented Jun 15, 2021

zulipbot commented Jun 15, 2021

zulipbot commented Jun 15, 2021

vinitwadgaonkar commented Jan 17, 2021 •

edited