Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override annotation for dispose methods in stores #110

Open
romatallinn opened this issue Sep 9, 2021 · 0 comments
Open

Override annotation for dispose methods in stores #110

romatallinn opened this issue Sep 9, 2021 · 0 comments

Comments

@romatallinn
Copy link

romatallinn commented Sep 9, 2021 •
edited

The lib/stores/language and lib/stores/theme have @override annotation on dispose() methods.

Is it intentional? It seems redundant and IDE warns it doesn't override anything. Maybe it's meant to be @action as in, for example, lib/stores/error?

CC: @zubairehman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romatallinn