Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZigBeeNode endpoint change due to firmware update #1088

Open
triller-telekom opened this issue Jul 20, 2020 · 3 comments
Open

ZigBeeNode endpoint change due to firmware update #1088

triller-telekom opened this issue Jul 20, 2020 · 3 comments
Labels
bug pinned Will not be closed, even if stale

Comments

@triller-telekom
Copy link
Contributor

As found in #1087 (comment) some devices might change their endpoints due to a firmware update.

Once the device announces itself via the DeviceAnnounce message, the corresponding ZigBeeNode has to be updated somehow.

@cdjackson
Copy link
Member

Throwing in a few thoughts here...

Ultimately we'd need to rediscover the node - this would need to remove all endpoints, and probably also the descriptors, from the ZigBeeNode and do a rediscovery. This would ensure that we account for any possible changes within the node (eg even changing it from a smoke sensor to a door sensor to a light bulb - if someone so desired).

I guess the big question is how to handle this - do we assume that since the firmware has changed, that the device could always have changed, and therefore after EVERY completed OTA that we should perform a rediscovery, or do we make this optional, or do we try and do something in-between. I'm tempted to say that we should always perform a rediscovery after every OTA completes - that ensures we know what the device has morphed into.

@triller-telekom
Copy link
Contributor Author

My first thought was that I could simply update the current node with "whatever comes in", but then I realized that we not not have much information about the device inside the DeviceAnnounce.

So yes, I agree, we would need to query everything from the device.

I haven't seen many zigbee devices that change during a firmware update, but I remember from a discussion in openHAB, that a firmware is basically what makes a devices. So if you change the firmware, you (potentially) get a different (type of) device, since features might have been added and/or removed.

Based on this, I would vote for re-discovering the node after each successful firmware update.

@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 19, 2020
@cdjackson cdjackson added pinned Will not be closed, even if stale and removed wontfix labels Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pinned Will not be closed, even if stale
Projects
None yet
Development

No branches or pull requests

2 participants