Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing issues with objects and arrays as keys in non-strict mode #193

Open
dominickpastore opened this issue May 21, 2020 · 0 comments · May be fixed by #194
Open

Parsing issues with objects and arrays as keys in non-strict mode #193

dominickpastore opened this issue May 21, 2020 · 0 comments · May be fixed by #194

Comments

@dominickpastore
Copy link

In jsmn, values are considered children of their key. (More specifically, the key has size 1, and the value's parent link points to the key).

This is fine in strict mode, but in non-strict mode, where arrays and objects can be keys, this is not so clean. In practice, the way this is implemented, whenever a value is parsed, it is made a child of the last token parsed.

Normally, this just means the last string/primitive token in an array/object used as a key will mistakenly have a size of 1. Not correct, but normally, the size of strings and primitives is ignored, so not a big deal.

However, if an empty array is used as a key, the parser makes more significant mistakes. For example, the following input:

{
    []: "value1",
    "key2": "value2"
}

produces output equivalent to this:

{
    [
        'value1',
        'key2'
    ]: 'value2'
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant