Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing isnan conditions #6

Open
tmIdiada opened this issue Jul 13, 2021 · 0 comments
Open

Missing isnan conditions #6

tmIdiada opened this issue Jul 13, 2021 · 0 comments

Comments

@tmIdiada
Copy link

Hi,

expr/expr.h

Line 370 in 5e7d72c

case OP_LOGICAL_OR:

If the first expression returns a NAN, then the second element is taken. If the second element is NAN, then a NAN is returned, otherwise 0.

From logical point of view NAN || logic expression returns a logic expression, but logic expression || NAN returns NAN. In general, I'm missing a lot of if isnan() conditions in the code to catch NAN values, for example also for OP_LOGICAL_AND, NAN would also occur here if and only if the second expression is NAN.

Kind regards,

Thaddäus

tmIdiada referenced this issue in esmini/esmini Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant