Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo owner to alias url. #8

Open
zpnk opened this issue Nov 26, 2016 · 1 comment
Open

Add repo owner to alias url. #8

zpnk opened this issue Nov 26, 2016 · 1 comment

Comments

@zpnk
Copy link
Owner

zpnk commented Nov 26, 2016

The current alias structure is of the form: {repo-name}-{my-branch}.

I think we should add the repo owner to the alias, for example: zpnk-hello-world-some-changes.

This will prevent collisions on project forks, etc.

@hawkins
Copy link

hawkins commented Jul 18, 2017

Is there any reason you don't use a hash or anything to practically guarantee collisions altogether?

For instance, if you pulled the branch's latest commit, you could take that commit's hash's first 7 digits and integrate it into the alias, similar to how non-aliased now deploys get named package-name-hashgoeshere.now.sh.

If you did this, the structure could be {user-name}-{repo-name}-{branch-name}-{commit-hash}. Granted this may be too long at this point, so you might consider cutting out the branch-name since that's now redundant, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants