Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support long branch names #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

littleStudent
Copy link

fixes #41

@paulirish
Copy link
Contributor

can you add a comment pointing to where the 70char max is defined or documented?

also... it'd seem slightly better if you set the const as 70 and do the math.

@littleStudent
Copy link
Author

littleStudent commented Nov 18, 2017

did not find anything in the docs. I ran into the problem and tested the constraints myself.
I will try to get an official statement in slack?

Sure i can do the calculation starting from the maxChar.

UPDATE:
I found this in the cli tool: https://github.com/zeit/now-cli/blob/c49ba28bbffe74860c845f313882b49c0e85988d/src/providers/sh/util/alias.js#L36

const domainRegex = /^((?=[a-z0-9-]{1,63}\.)(xn--)?[a-z0-9]+(-[a-z0-9]+)*\.)+[a-z]{2,63}$/

So as i see it we got 63 chars to choose + .now.sh (7 chars) = 70chars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid alias because of maximum character count
2 participants