Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker deployments fail #39

Open
hugomd opened this issue Nov 8, 2017 · 3 comments · May be fixed by #48
Open

Docker deployments fail #39

hugomd opened this issue Nov 8, 2017 · 3 comments · May be fixed by #48

Comments

@hugomd
Copy link
Contributor

hugomd commented Nov 8, 2017

Originally raised here.

The npm build script isn't being run in Docker, it simply installs and then runs.

stage-ci/package.json

Line 10 in 408f6a0

"build": "node ./src/build.js",

stage-ci/Dockerfile

Lines 7 to 14 in 408f6a0

COPY package.json .
RUN npm install --production
ADD . .
EXPOSE 3000
CMD npm start

When now spins up a new deployment, it runs the build step automatically.

I can see two ways to fix this:

  1. Update the Dockerfile to include the build step
  2. Rename the build script to preinstall

✌️
@imevro
Copy link

imevro commented Dec 20, 2017

@zpnk ping?

@cmalard cmalard mentioned this issue Apr 26, 2018
Open
@hugomd
Copy link
Contributor Author

hugomd commented Jun 17, 2018

I'm giving this a go now 👍

@hugomd hugomd linked a pull request Jun 18, 2018 that will close this issue
Open
@hugomd
Copy link
Contributor Author

hugomd commented Jun 21, 2018

Fixed in #48 🐳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Docker deployments 🐳 hugomd/stage-ci
2 participants
@imevro @hugomd