Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in console when using imageSettings without width/height #104

Open
guido-visser opened this issue Mar 10, 2020 · 1 comment
Open

Comments

@guido-visser
Copy link

guido-visser commented Mar 10, 2020

When I add

{
src: "URL_TO_IMAGE.svg",
excavate: true
}

I get errors in the console, saying that the width and height in the imageSettings prop are required, but the docs say that the default is 10%

Reproduced link:
https://codesandbox.io/s/qrcodereact-error-in-console-sxv6e

@zpao
Copy link
Owner

zpao commented Mar 13, 2020

It's a little messy. You really should be passing in these values as the fallback is really dumb and will not scale images evenly (will always make them square). It's really just there to prevent things from exploding. I should update the docs to be clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants