Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze diffie-hellman 5.0.3 #1011

Open
balhar-jakub opened this issue Mar 6, 2024 · 2 comments
Open

Analyze diffie-hellman 5.0.3 #1011

balhar-jakub opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels

Comments

@balhar-jakub
Copy link
Member

No description provided.

@1000TurquoisePogs
Copy link
Member

we use this library because of a performance regression on node long ago.
i would like to retest this to see how native vs library compares today to see if it can be removed.

@1000TurquoisePogs
Copy link
Member

using crypto in node is still extraordinarily slow, which was the reason we used this diffie-hellman instead.
however, research revealed crypto.webcrypto has functions that are implemented differently that may be faster than both. so, it'd be great to move to that, but unfortunately the API is organized differently so our code would need to change for SSH.

Rather than improve our ssh parser i'd rather move to a different ssh library, which has been on the to-do list forever. ( #427 ) ( https://www.npmjs.com/package/ssh2 )

Basically, there's nothing to do with this library now, but I would like to find a better solution long-term as it was never desired to begin with.

@1000TurquoisePogs 1000TurquoisePogs self-assigned this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

2 participants