New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProQuest Ebook Central: Broken on Firefox and Safari #3254
Comments
@adomasven, any idea what's going on here? The outer page is
Adding |
See zotero/translators#3254 Also: - Improve _updateInfoForTab() to explicitly list available tab info - Fix a bug where a refresh of a page that has higher priority frame translators won't inject into that frame - Improve script injection log message with frame URL
See zotero/zotero-connectors#156 Basically when we moved from the native Firefox extension to BrowserExt we had performance issues injecting the translation framework into every frame, so a number of changes followed. The current code injects the translator framework into the first iframe on the page, which works for the majority of cases where translation needs to run in the frame.
I'm not seeing this. It saves fine for me.
This was broken in Firefox. There was actually a fix, but it didn't work. I've now updated the connector code to fix it properly. It's still broken in Safari, because we don't have the mechanism to run translation on the first frame there, but it may be possible to make it work. I've created an issue for that zotero/zotero-connectors#463 |
I see that we don't actually have a single translator with |
e.g. https://www.proquest.com/docview/2891926759/ (access varies by institution, this should be pretty common)
Works on Edge/Chrome, broken on Firefox (and apparently Safari): https://forums.zotero.org/discussion/111856/proquest-not-recognizing-item-type#latest
The text was updated successfully, but these errors were encountered: