Add translator for CITATION.cff file references (CFF-References)
#3274
+170
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm uncertain about the best way to proceed with adding tests for a translator. Any guidance would be much appreciated! In case of no reply I'll also reference existing PR's for an idea of how to do this. |
|
We don't currently add export tests |
|
Sounds good, thanks @adam3smith ! |
AbeJellinek
requested changes
Mar 19, 2024
- Fix writeArray so it works for more than tags - Fix regex in writeArray - Remove extra newlines at end of some written values - Remove link to unrelated localization file - "collection_title" maps to proceedingsTitle - Fix repository self-assignment - Map correspondence authors to "senders" and all primary creator types (not just author) to "authors" - Fix DOI regex for multiline extra - Remove extra special case for authors and keywords - Try to avoid outputting invalid YAML for multiline abstracts - Fix some lint errors
|
@adam3smith: I think this is ready, but it's always good to get a third set of eyes on import/export translators. Look OK? |
|
(@d33bs, thanks for adding all those mappings! Sorry again for ballooning the amount of work this translator would need.) |
|
No worries @AbeJellinek , thank you again for the great feedback - fun to go deeper with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends on the work originally provided by @adam3smith for the CFF translator as a new translator called "CFF-References". The purpose of this translator is to help translate Zotero resources into a CITATION.cff file's
referencesitem.Thank you in advance for any thoughts and feedback you may have! Please don't hesitate to let me know if I may change or improve this to help make it more useful to others.
Closes #3250