Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of Mastodon translator #3218

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

UniqueClouds
Copy link

This is intended to fix zotero/translators#3214

I have added a new parse function parseMastonURL to handle different URL formats

UniqueClouds and others added 4 commits January 8, 2024 10:12
I have added a new parse function `parseMastonURL` to handle different URL formats
This is intended to address the [issue#3188](zotero#3188)

I have made two modifications.
1. Modify `detectWeb` function to ensure that OSF Projects are recognized as "Web Page" instead of "Journal Article."
2. Modify `scrape` function to customize the citation information for OSF Projects.
@AbeJellinek
Copy link
Member

AbeJellinek commented Jan 9, 2024

Thanks, this looks good! A few things:

  • Separate out the OSF changes - looks like that shouldn't have been added to this PR.
  • Update the tests / add one for the issue this fixes. Scaffold (Tools -> Developer -> Translator Editor) will do that for you.
  • Update lastUpdated. Scaffold does that automatically on save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Mastodon translator saves incorrect URL
2 participants