Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zotero translate uses monogr/imprint/note where monogr/ptr would be more appropriate #3171

Open
sydb opened this issue Oct 25, 2023 · 1 comment

Comments

@sydb
Copy link

sydb commented Oct 25, 2023

I do not use Zotero myself, but am in the position of processing TEI <biblStruct> elements that are generated by Zotero translator. I noticed that the URL of the document being referenced is included as a <note type="url"> child of the <imprint> (which is a child of the <monogr>).

This information should probably be recorded on the @target of a <ptr> (perhaps with a @type attribute of some sort) that is a direct child of the <monogr> instead. (The same is true for <analytic> and <series>, but a <note type="url"> does not occur in those elements in my dataset.)

In fact, the Best Practices for TEI in Libraries (v4) explicitly recommends <ptr> as a child of <monogr>, <analytic>, or <series> for this purpose. (However, they imply that in the case of a <monogr>, the <ptr> should go after the <imprint>, but it is not allowed there. It would typically go after the <title>. Guess that’s another issue to file …)

I would take a crack at fixing this myself, but I do not really speak Javascript. But I think the notes I am complaining about are generated at lines 501–506.

@AbeJellinek
Copy link
Member

@adam3smith, know anything about this? It seems like a straightforward fix, but I know zero about this translator or format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants