Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging subject images ignores rotation transforms #6067

Open
1 of 6 tasks
eatyourgreens opened this issue Apr 28, 2024 · 3 comments · May be fixed by #6065
Open
1 of 6 tasks

Dragging subject images ignores rotation transforms #6067

eatyourgreens opened this issue Apr 28, 2024 · 3 comments · May be fixed by #6065
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Apr 28, 2024

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Describe the bug

Dragging a rotated subject image ignores the rotation transformation, leading to weird and unexpected UX eg. I drag right but the image moves up (its RHS in the rotated frame.)

Panning with the keyboard isn't affected, only dragging with a pointer (mouse, trackpad or finger.)

Screen.Recording.2024-04-28.at.22.04.20.mov

To Reproduce

Zoom an image, either in or out, rotate it, and drag the rotated image to move.

Expected behavior

Dragging should move the image in the frame of the subject viewer, not the rotated frame of the image eg. dragging right should move the rotated image to my right.

Device information

Tested in desktop Firefox and Chrome, and mobile Safari on an iPhone XS. This seems to be a bug in the Zooniverse SVG code, not a browser bug.

Additional context

Dragging worked correctly when rotation was first introduced, for transcription projects.

@eatyourgreens eatyourgreens added the bug Something isn't working label Apr 28, 2024
@eatyourgreens
Copy link
Contributor Author

After a bit of testing on a drawing workflow, on my phone, dragging to draw is not affected by this bug. Only dragging to move the image. 🤔

https://frontend.preview.zooniverse.org/projects/eatyourgreens/-project-testing-ground/classify/workflow/3370?env=staging

@goplayoutside3
Copy link
Contributor

Related to #2273

@eatyourgreens eatyourgreens linked a pull request Apr 30, 2024 that will close this issue
12 tasks
@eatyourgreens
Copy link
Contributor Author

Both #2273 and this issue should be fixed in #6065.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants