Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a hotkey to play a subject #6064

Open
6 tasks
seanmiller26 opened this issue Apr 26, 2024 · 4 comments
Open
6 tasks

Enable a hotkey to play a subject #6064

seanmiller26 opened this issue Apr 26, 2024 · 4 comments
Labels
accessibility Improving the experience for users of assistive technologies enhancement New feature or request

Comments

@seanmiller26
Copy link
Contributor

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Is your feature request related to a problem? Please describe.

Let's give volunteers the option of having a dedicated key that they can use to play/pause video/flipbook subjects.

Describe the solution you'd like

The letter P which stands for play/pause, for instance.

Additional context

Add any other context or screenshots about the feature request here.

@seanmiller26 seanmiller26 added enhancement New feature or request accessibility Improving the experience for users of assistive technologies labels Apr 26, 2024
@eatyourgreens
Copy link
Contributor

FWIW, the video player uses space to play/pause, which is pretty standard for media players on the web. You do have to focus the player first, either by clicking on it or tabbing to it.

@eatyourgreens
Copy link
Contributor

Here's a video of me using the video keyboard controls to play a video in Chrome. When the video player has keyboard focus:

  • Space toggles play/pause.
  • The cursor keys scrub backwards and forwards through a paused video.
Screen.Recording.2024-05-03.at.14.39.02.mov

@eatyourgreens
Copy link
Contributor

eatyourgreens commented May 4, 2024

The space bar also toggles play/pause in the flipbook viewer, when the subject image is focused (tested on Daily Minor Planet.)

There is one difference from PFE. With PFE, I can click a subject to focus it. FEM subjects aren’t clickable like that. I have to tab to the subject image, which is inconvenient.

Try it on Daily Minor Planet here. Tab through the page until the subject image is selected, and you'll find that you can toggle play/pause with the spacebar. There is one, big, level AA accessibility failure on that page: the subject image is focusable but has no visible focus indicator in Firefox.

In Chrome, the focused image has a thin blue focus indicator, which would probably also fail. It's really easy to miss in this screenshot.

Daily Minor Planet in Chrome, with the dark theme. The subject image has a thin blue focus indicator, easily lost against the black page background.

@eatyourgreens
Copy link
Contributor

For keyboard and screen reader users, I would suggest:

  • have skip links that take you from the top of the page to the classifier (or the classifier subject?)
  • have clear focus indicators to indicate that the flipbook player or video player has focus.
  • enable volunteers to select the player by clicking/tapping on it.
  • communicate that both players support standard keyboard shortcuts that volunteers are probably already accustomed to from other sites (eg. YouTube?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improving the experience for users of assistive technologies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants