Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Grommet theme font sizes in rem & line-height in unitless numbers #6028

Open
goplayoutside3 opened this issue Apr 11, 2024 · 0 comments
Labels
accessibility Improving the experience for users of assistive technologies design Design and/or UX

Comments

@goplayoutside3
Copy link
Contributor

goplayoutside3 commented Apr 11, 2024

Package

lib-grommet-theme

Is your feature request related to a problem? Please describe.

To increase platform-wide accessibility we should define our font sizes in rem units rather than hardcoded pixels. It's also preferred to define line-height as a unitless ratio rather than pixels.

Describe the solution you'd like

The size (font-size) prop in our Grommet theme components should be redefined for paragraphs, text, and headings. Each are linked below, and also have a height prop which corresponds to line-height.

Paragraphs

Text

Headings

heading: { // medium is the default

Additional context

Building upon #6007

Related to: #5469

@goplayoutside3 goplayoutside3 added accessibility Improving the experience for users of assistive technologies design Design and/or UX labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improving the experience for users of assistive technologies design Design and/or UX
Projects
None yet
Development

No branches or pull requests

1 participant