Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiframe subjects: Drawing tools only render previous marks for the active frame #5929

Open
1 of 6 tasks
eatyourgreens opened this issue Feb 19, 2024 · 0 comments · May be fixed by #5923
Open
1 of 6 tasks

Multiframe subjects: Drawing tools only render previous marks for the active frame #5929

eatyourgreens opened this issue Feb 19, 2024 · 0 comments · May be fixed by #5923
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Feb 19, 2024

Package

Choose from the list:

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-panoptes-js
  • lib-react-components
  • unknown

Describe the bug

Drawing annotations only record marks for the active frame in annotation.value. As a result, when previous marks are rendered, they only show marks in the active frame (for a multi-frame subject.)

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.zooniverse.org/projects/communitiesandcrowds/how-did-we-get-here/classify/workflow/23790
  2. Draw lines on both frames of a subject.
  3. Answer the yes/no question and click Next.
  4. The subject now only shows lines that you drew on the active frame.
  5. Go back to the previous step and change the active frame.
  6. Add a new line.
  7. Click Next and see that only the active frame has lines again.

Expected behavior

All the marks that you've made should be stored in annotation.value and shown.

Additional context

When you save a classification, by pressing Done, annotation.value is ignored. The saved annotation is generated from task.marks, so saved classifications aren't missing any marks. annotation.value is out of sync with task.marks for drawing and transcription annotations.

Stories and tests only mock a single subject frame, so this bug isn't picked up in CI.

@eatyourgreens eatyourgreens added the bug Something isn't working label Feb 19, 2024
@eatyourgreens eatyourgreens linked a pull request Feb 19, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant