Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight junit 5 support and required changes todo in documentation #230

Open
swapy opened this issue Mar 27, 2023 · 2 comments
Open

Highlight junit 5 support and required changes todo in documentation #230

swapy opened this issue Mar 27, 2023 · 2 comments
Labels
type: documentation A documentation update

Comments

@swapy
Copy link

swapy commented Mar 27, 2023

Thank you very much @tomix26 for this wonderful project. All efforts appreciated.

I would like to suggest an improvement for docs. Can we mention more about Junit 5 support in documentation?

  • required changes to do if any
  • unsupported annotation if any eg: @RepeatedTest

Thanks.

@tomix26
Copy link
Collaborator

tomix26 commented Mar 30, 2023

JUnit5 should be supported out of the box, including the @RepeatedTest annotation. All testing frameworks supported by Spring are also supported by this library. I could update the code examples from JUnit4 to JUnit5, but I don't find it particularly important. Or would you suggest any other changes to the documentation?

@tomix26 tomix26 added the status: waiting-for-feedback We need additional information before we can continue label Mar 30, 2023
@swapy
Copy link
Author

swapy commented Apr 4, 2023

I would suggest adding one more section mentioning example on how to use with Junit5

example, now I have to go with SpringExtension and it works

@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@ActiveProfiles("pgsqltest")
@ExtendWith(SpringExtension.class)
@AutoConfigureMockMvc
@AutoConfigureCache
@AutoConfigureEmbeddedDatabase(refresh = AFTER_EACH_TEST_METHOD, provider = AutoConfigureEmbeddedDatabase.DatabaseProvider.ZONKY, type = AutoConfigureEmbeddedDatabase.DatabaseType.POSTGRES)
@TestPropertySource(properties = {"spring.config.location=classpath:application-pgsqltest.yml"})
class PersonTestIT {
...
}

@tomix26 tomix26 added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants