Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill notes #149

Open
DigiBear opened this issue Mar 16, 2018 · 3 comments
Open

Skill notes #149

DigiBear opened this issue Mar 16, 2018 · 3 comments

Comments

@DigiBear
Copy link

A lot of classes have abilities that have effects on skills e.g. Ranger's [Favored Enemy and Terrain], a barbarian 's [Rage] and the Slayer's [Study target].

Having either a section for notes underneath and/or a way to mark separate skills could greatly help in keeping track of those.

I added a photoshopped version for clarification
skills

of course just adding a skills note option is more than sufficient as well.

@zombieFox
Copy link
Owner

This is an interesting idea. If I understand the feature you are describing correctly this would require class specific data with a way to support the characters current "status". I've thought about building something which supports states like "blinded" or "fatigued" etc. However such a feature represents a lot of work. I can investigate what else this might involve.

In the short term I've gone ahead and added a note area for the skill section.

@DigiBear
Copy link
Author

DigiBear commented Mar 22, 2018

Not necessarily. You could have the icons be capable of being applied the same way you prepare spells etc. You already have that icon system in place, all that would be needed is perhaps expansion on the total amount of icons and a way to make specific notes on the meaning of that mark.

That last part you could probably reuse the code you made for abilities for, just let people apply an icon, a title and notescand you should have all that you need.

Adding the class specific data should be a quality of life improvement, cool but not needed.

Hope that helps!

I also found that crafts and professions only show a number behind them instead of the given name, I don't know if that was intended but it seems more convenient to me if it displays the given name. I can make a separate issue of it if you prefer.

@zombieFox
Copy link
Owner

The crafts and professions Skill Names not showing was a bug which is now fixed. Thanks for pointing that out!

I think this needs more thought on my part about how best to support conditional changes to Skill totals (and other abilities) and how to present that information on the display mode. The Pill with notes method might indeed work.

From a code perspective, the Pill module will eventually replace the Spells module once it supports the same functionality. (I've been planning to deprecate it for a while now.)

I've added a task to the Project board for now, I'm afraid this may be a long term goal for awesomeSheet.

Thanks for all the feedback and suggestions so far : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants