Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug report] wrong implementation of gradient clip in WGAN? #31

Open
KK666-AI opened this issue Apr 25, 2021 · 1 comment
Open

[bug report] wrong implementation of gradient clip in WGAN? #31

KK666-AI opened this issue Apr 25, 2021 · 1 comment

Comments

@KK666-AI
Copy link

Dear author,

Thanks for your friendly implementation of popular GANs. I am reading your implementation of Wasserstein GANs, and notice that the gradient clip operation is placed after optimizer.step as seen in this line.
Typically, in pytorch, the gradient operation is placed before the optimizer step.

pls have a check.

@Wuziyi616
Copy link

As you can see in this line for p in self.D.parameters(): this is not performing gradient clipping but params value clipping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants