Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SHA512 auth #15

Open
muesli opened this issue Feb 22, 2018 · 2 comments
Open

Support SHA512 auth #15

muesli opened this issue Feb 22, 2018 · 2 comments
Assignees

Comments

@muesli
Copy link
Collaborator

muesli commented Feb 22, 2018

Currently only SHA1 is supported.

@znuh
Copy link
Owner

znuh commented Mar 24, 2018

Worked on this for a bit but since it's not the reason why nordvpn doesn't work I don't really see a reason to finish this at the moment. Therefore I moved the SHA512 stuff to a different branch and removed it from master again to keep master as lean as possible.
There's still stuff missing in the hmac_sha512 branch before SHA512 could work:
ovpn_ctl.c:113: uint8_t hmac[20]; /* TODO: what about SHA512? */
ovpn_ctl.c:146: return compare_hmac(buf, hdr->hmac, 20); /* TODO: what about SHA512? */
Apart from this the hmac_sha512 branch is completely untested at the moment and SHA1 might even be broken there as the branch is completely untested.

@nihilus
Copy link

nihilus commented Jul 2, 2018

Seems like a C union is the perfect solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants