Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectableMath's selection toolbar won't appear in mobile browsers in most cases #13

Open
znjameswu opened this issue Oct 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@znjameswu
Copy link
Owner

Currently SelectableMath employed a hack to get righ-click context menu on desktop web, as discussed in #10 (comment). However this has an unexpected side effect, because it breaks mobile browsers's selection toolbar.

On mobile web, the position of selection toolbar depends on the actual position of the underlying textarea (doesn't matter if Flutter Web clips it or not). If we make the textarea riduculously large, then the selection toolbar will fly outside the viewport in most cases.

@znjameswu
Copy link
Owner Author

I think it's better to drop the idea of using "native" context menu on web. MathQuill failed achieve it either. In fact, no web implementations did this with a native context menu. They all intercept the right click event and override with their custom context menu. Current Flutter can't do that easily.

Also, desktop web can still copy by ctrl+C in the future.

Once flutter/flutter#31955 is resolved, native context menu on web will be dropped and replaced with a custom one. Currently they are still useful for web demos.

@znjameswu znjameswu added the bug Something isn't working label Nov 20, 2020
creativecreatorormaybenot added a commit to simpleclub-extended/flutter_math that referenced this issue Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant