Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trackNumber should return empty string if a track has no trackNumber encoded in its metadata #3

Open
porg opened this issue May 30, 2022 · 4 comments
Labels

Comments

@porg
Copy link

porg commented May 30, 2022

Reproduction

  • In /Volumes/iTunesFS/AlbumsTrackFormat.txt
    • I tried %(playlistNumber#000) %(artist) - %(album) - %(trackNumber#00) %(name).%(ext.lowercaseString)
    • and later %(playlistNumber#000) %(artist) - %(album) - %(trackNumber) %(name).%(ext.lowercaseString)
  • Actual: In both configurations tracks without a track number produce "0".
  • Expected: A track not having a track number should produce an empty string.
  • Or we could introduce trackNumberNull="" and you can leave this empty or define any custom format you like in the absence of a trackNumber, like "xx" or "•".
@znek znek added the bug label May 30, 2022
@znek
Copy link
Owner

znek commented May 31, 2022

All relevant numbers are ordinals which start at 1 (not 0), hence 0 can always be considered as not being set and will now be discarded when being formatted. Fixed in [74ad41d].

@porg
Copy link
Author

porg commented May 31, 2022

Great!
Could you make this available as a new build so that I can test it out?
I would then report the results of my testing here.

@znek
Copy link
Owner

znek commented Jun 1, 2022

iTunesFS-2.0.1.dmg

@porg
Copy link
Author

porg commented Jun 2, 2022

Tested 2.0.1

  • Works: If no track number exists it outputs NULL.

But I just detected a followup issue

/Volumes/iTunesFS/PlaylistsTrackFormat.txt
%(artist) - %(album) - %(trackNumber#00) %(name).%(ext.lowercaseString)

/Volumes/iTunesFS/Playlists/Sample Playlist

  • 2raumwohnung - Kommt Zusammen - 01 Kommt zusammen.mp3

  • 2raumwohnung - Kommt Zusammen - 02 Du und Ich.mp3

    • ✅ as long as artist album and trackNumber exist it works fine.
  • Euji Acha Obnixophineles.mp3

  • sco Definition.mp3

    • If the trackNumber does not exist it is omitted.
    • But also the separator/freetext between is gone.
    • Artist and Songname succeed directly without any separator
  • What I rather wanted in those cases was:
    👉 Euji Acha - Obnixophineles.mp3
    👉 sco - Definition.mp3

Followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants