Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the disassembly of map headers #63

Open
kemenaran opened this issue Oct 9, 2018 · 1 comment
Open

Improve the disassembly of map headers #63

kemenaran opened this issue Oct 9, 2018 · 1 comment
Labels
help wanted contributions gladly accepted

Comments

@kemenaran
Copy link
Collaborator

For now map headers data is not separated from the map blocks.

It looks like this:

Overworld00::
  db   $0B, $E5, $8A, $00, $00, $8A, $10, $00, $8A, $20, $EF, $10, $7C, $11, $7D, $19, $7C, $13, $80, $84, $14, $4D, $17, $81, $23, $37, $83, $24, $0A, $27, $38, $32, $1D, $33, $2E, $34, $48, $36, $49, $37, $4E, $38, $5D, $41, $1D, $42, $37, $43, $39, $44, $E1, $E1, $07, $3A, $58, $10, $82, $45, $3A, $C2, $35, $E0, $47, $3B, $48, $38, $50, $1D, $C3, $51, $37, $C2, $52, $37, $85, $53, $09, $82, $58, $7A, $C2, $60, $37, $85, $63, $09, $68, $38, $72, $2E, $85, $73, $2F, $78, $4E, $69, $50, $79, $09, $FE

This should be improved, by:

  • Documenting the header structure (in tools/generate_map_data.py) ;
  • Maybe moving the blocks to separate files (like data/blocks/overworld_00.blk).

It could look like this:

Overworld00::
  db ANIMATION_TARAMANCH ; animated tiles set
  db WALLS_NONE | FLOOR_MOUNTAINS ; walls and floor type
  incbin 'data/blocks/overworld_00.blk'

All this data is already parsed by tools/generate_map_data.py. It should just be a matter of augmenting the script to output the right informations.

@kemenaran
Copy link
Collaborator Author

Much improved by #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted contributions gladly accepted
Projects
None yet
Development

No branches or pull requests

1 participant