Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Velocity to Speed #369

Open
kemenaran opened this issue May 19, 2021 · 5 comments
Open

Rename Velocity to Speed #369

kemenaran opened this issue May 19, 2021 · 5 comments
Labels
good first issue suited for an easy first contribution help wanted contributions gladly accepted

Comments

@kemenaran
Copy link
Collaborator

Most speed-related variables are named Speed-Something – but some still use the outdated Velocity name.

We should rename variables and comments so that “speed” is used everywhere.

@kemenaran kemenaran added help wanted contributions gladly accepted good first issue suited for an easy first contribution labels May 19, 2021
@daid
Copy link
Collaborator

daid commented May 19, 2021

I disagree.

I would say "velocity" is something actual, like, if you are walking to the right, link's velocity is 1 pixel per frame. But "speed" is something constant/config, even if you are standing still, link's speed while walking right is 1 pixel per frame. (atleast, that is how I always use velocity vs speed)

@kemenaran
Copy link
Collaborator Author

Hmm, interesting. Like speed is a fixed attribute of an entity (how fast can it move?), and velocity is “how fast does it moves right now”?

In that case making the variables consistent probably means renaming them to Velocity rather than Speed.

@daid
Copy link
Collaborator

daid commented May 20, 2021

Hmm, interesting. Like speed is a fixed attribute of an entity (how fast can it move?), and velocity is “how fast does it moves right now”?

Yes, that's how I usually use it. But other people will most likely disagree, we are on the internet after all :D

@ealvesss
Copy link

Can I Get This Issue?

@daid
Copy link
Collaborator

daid commented Dec 29, 2023

You can do what you want, we dont work as a strict organization here.

ealvesss added a commit to ealvesss/LADX-Disassembly that referenced this issue Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue suited for an easy first contribution help wanted contributions gladly accepted
Projects
None yet
Development

No branches or pull requests

3 participants