Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label the steps of the photo picture cutscenes #118

Open
kemenaran opened this issue Sep 25, 2019 · 0 comments
Open

Label the steps of the photo picture cutscenes #118

kemenaran opened this issue Sep 25, 2019 · 0 comments
Labels
good first issue suited for an easy first contribution

Comments

@kemenaran
Copy link
Collaborator

A little cutscene plays when taking each photo picture. These cutscenes are defined in https://github.com/zladx/LADX-Disassembly/blob/master/src/code/photos.asm.

Each cutscene is splitted into several small fragments:

  • loading resources,
  • starting the cutscene until the first step is reached,
  • starting to play the next sequence in the cutscene, etc.

These steps are not labeled for now. It should be relatively easy to understand what each step does.

The wGameplaySubtype variable (at $DB96) controls the steps of a cutscene: by watching its value change during gameplay in a debugger, it should help understand which step is what.

To access each cutscene individually, you can either:

  • During gameplay, manually set the value of $DB95 in a debugger to a value between $0E and 1A, and $DB96 to 0. This will bring you directly to the cutscene.
  • Or, at compile-time, enable the ROM_DebugTool3 value. Then use the built-in debug commands to access a fully-filled photo album.
@kemenaran kemenaran added enhancement help wanted contributions gladly accepted labels Sep 25, 2019
@kemenaran kemenaran added good first issue suited for an easy first contribution and removed help wanted contributions gladly accepted labels Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue suited for an easy first contribution
Projects
None yet
Development

No branches or pull requests

1 participant